This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Oja hg fix h2 #223
Merged
Oja hg fix h2 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These erreonous text nodes are added when the market is appended at the *start* of a block element.
| @@ -445,4 +445,23 @@ describe('commands', function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe.only('formatBlock heading', function () { | |||
There was a problem hiding this comment.
Did you mean to commit .only?
| givenContentOf('<h2>1|</h2>', function () { | ||
| when('the formatblock command is executed with h2', function() { | ||
| beforeEach(function () { | ||
| return scribeNode.sendKeys(webdriver.Key.LEFT).then(function () { |
There was a problem hiding this comment.
We should leave a comment to note what bug this test is trying to re-produce.
We're currently linking tests with patches just by duplicating comments and the links to isolated test cases. This could be done better: #93 (comment)
|
Nice work! |
|
I think it's more your work! |
|
All tests working fine |
| * | ||
| */ | ||
| describe('formatBlock heading', function () { | ||
| givenContentOf('<h2>1|</h2>', function () { |
There was a problem hiding this comment.
Wrong indentation? Two spaces…
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a fix for a bug when Chrome inserts extra text elements after a change of focus (i.e. a button click) and leaves unwanted H2 elements in the remaining markup
See the large comment above the change code for more.