Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Spacing in input fields #998

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Spacing in input fields #998

merged 6 commits into from
Oct 1, 2021

Conversation

coldlink
Copy link
Member

@coldlink coldlink commented Sep 30, 2021

What is the purpose of this change?

Screenshot 2021-09-28 at 10 37 29 (1)

To update the spacing in input field components (TextInput/TextArea) between the input element and the labels to match closer to design requirements.

What does this change?

  • Adding a 2px margin-top to the supporting text in the label component, to space it from the main label text
  • Updates the TextInput component to apply the spacings between the label component, inline messages, and input field.
  • Updates the TextArea component to apply the spacings between the label component, inline messages, and input field.
  • A margin wasn't added when an inline error/success was visible, as there is already quite a bit of space when it's visible.

Screenshots

chrome_aTPt7lXXLp

chrome_FQTfyF876v

chrome_JpXUhHxcCH

Checklist

Accessibility

Cross browser and device testing

  • Tested with touch screen device

Responsiveness

  • Tested at all breakpoints
  • Tested with with long text
  • Stretched to fill a wide container

Documentation

  • Full API surface area is documented in the README
  • Examples in Storybook

Known issues

@probot-autolabeler probot-autolabeler bot added the Text input Changes to the text input component label Sep 30, 2021
@probot-autolabeler probot-autolabeler bot added the Label Changes to the label component label Sep 30, 2021
@coldlink coldlink changed the title Add margin-top to TextInput Spacing in input fields Sep 30, 2021
@probot-autolabeler probot-autolabeler bot added the Text area Changes to the text area component label Oct 1, 2021
@coldlink coldlink marked this pull request as ready for review October 1, 2021 08:58
@coldlink coldlink requested a review from a team as a code owner October 1, 2021 08:58
Copy link
Contributor

@SiAdcock SiAdcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all your hard work @coldlink! 💎

@SiAdcock SiAdcock merged commit 95e2a32 into main Oct 1, 2021
@SiAdcock SiAdcock deleted the mm/text-input-margin branch October 1, 2021 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Label Changes to the label component Text area Changes to the text area component Text input Changes to the text input component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants