Automat 0.3 changes #194
Merged
Automat 0.3 changes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicl
force-pushed
the
nicl/automat-0.3-changes
branch
2 times, most recently
from
e18ad2f
to
eb02758
Compare
tompretty
reviewed
Jul 23, 2020
|
@tompretty ah thanks - yes almost certainly. I probably need to add the babel plugin - will take a look. Update: this should be okay now. |
nicl
force-pushed
the
nicl/automat-0.3-changes
branch
2 times, most recently
from
6736e20
to
4057d5c
Compare
nicl
added a commit
to guardian/frontend
that referenced
this pull request
Jul 23, 2020
This includes switching to the v2 of automat client libraries, and loading the epic as an ES module. See also: guardian/support-dotcom-components#194 https://github.com/guardian/automat-client-v2/ https://docs.google.com/document/d/1CVkWvCo5SlJjedPmv0Uh6gQ6mwFsGydE2RvZzo6uxGk/edit?usp=sharing
tompretty
approved these changes
Jul 24, 2020
nicl
added a commit
to guardian/frontend
that referenced
this pull request
Jul 27, 2020
This includes switching to the v2 of automat client libraries, and loading the epic as an ES module. See also: guardian/support-dotcom-components#194 https://github.com/guardian/automat-client-v2/ https://docs.google.com/document/d/1CVkWvCo5SlJjedPmv0Uh6gQ6mwFsGydE2RvZzo6uxGk/edit?usp=sharing
This is required to use the emotion cache, which Automat uses as part of its shadow dom support. In addition, Source uses @emotion/core and standardising helps avoid having to load both. Note, an interesting discussion on the differences between emotion and @emotion/core can be found here: emotion-js/emotion#1883.
Currently failing on .? and ?? operators.
nicl
force-pushed
the
nicl/automat-0.3-changes
branch
from
4057d5c
to
64c3e37
Compare
nicl
added a commit
to guardian/frontend
that referenced
this pull request
Jul 28, 2020
This includes switching to the v2 of automat client libraries, and loading the epic as an ES module. See also: guardian/support-dotcom-components#194 https://github.com/guardian/automat-client-v2/ https://docs.google.com/document/d/1CVkWvCo5SlJjedPmv0Uh6gQ6mwFsGydE2RvZzo6uxGk/edit?usp=sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - required changes in platforms first. guardian/dotcom-rendering#1758 and also the Frontend PR which must be merged at the same time (so we'll have a few minutes with no subs/contributions banners on Frontend).
What does this change?
Various changes to support the newer automat clients. See:
https://docs.google.com/document/d/1CVkWvCo5SlJjedPmv0Uh6gQ6mwFsGydE2RvZzo6uxGk/edit?userstoinvite=tom.forbes%40guardian.co.uk&ts=5f16bd85&actionButton=1#
https://github.com/guardian/automat-client-v2/
for more info here.
The summary is:
emotionto@emotion/core@guardian/automat-depsto help ensure react/emotion versions safeemotionandemotion-theming)How to test
Run the tests, and also test with Frontend or DCR.
How can we measure success?
Able to support modules on Frontend (as a separate change but this is a step towards that).
Have we considered potential risks?
I haven't tested the banners yet.