Add revenue recognition logic for DS gifts that are refunded or expired #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
commented
Jul 6, 2021
handlers/revenue-recogniser-job/src/main/scala/com/gu/recogniser/Handler.scala
Outdated
Show resolved
Hide resolved
johnduffell
commented
Jul 6, 2021
rupertbates
reviewed
Jul 6, 2021
handlers/revenue-recogniser-job/src/main/scala/com/gu/recogniser/Handler.scala
Outdated
Show resolved
Hide resolved
rupertbates
approved these changes
Jul 6, 2021
johnduffell
force-pushed
the
jd-recognise-gift-revenue
branch
from
5d83907
to
20583c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extra logic to actually distribute the revenue for DS gifts that have been refunded, or that have expired.
This is needed so that finance team can correctly attribute the revenue from DS gifts even where they were not redeemed or were refunded.
This is very general now, so it would actually distribute the original schedule, as well as any refunds, so we can get rid of this logic: https://github.com/guardian/support-frontend/blob/e4837caea99cb1c63ad8bdd55a142b413d15af1f/support-services/src/main/scala/com/gu/zuora/ZuoraGiftService.scala#L103