Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Add country codes #123

Merged
merged 2 commits into from
May 11, 2021
Merged

Add country codes #123

merged 2 commits into from
May 11, 2021

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 11, 2021

What does this change?

adds the country code types defined currently in @guardian/libs

@sndrs sndrs requested a review from JamieB-gu May 11, 2021 14:06
@sndrs sndrs requested a review from mxdvl May 11, 2021 14:08
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these places you cannot go to!

PS. Remember to manually bump the version, too.

@sndrs sndrs merged commit 4ffeb6f into main May 11, 2021
@sndrs sndrs deleted the country-codes branch May 11, 2021 15:16
@JamieB-gu
Copy link
Contributor

Nice! How do you envisage types and libs interacting going forward?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants