Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Rename Design.GuardianView To Design.Editorial #68

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

JamieB-gu
Copy link
Contributor

Why?

We'd like to rename Design.GuardianView to Design.Editorial.

  1. To keep its name consistent with how it's referred to elsewhere.
  2. To keep it internally consistent with how other Designs are named (i.e. they're not prefixed with the word Guardian).

Changes

  • Rename Design.GuardianView to Design.Editorial

@JamieB-gu JamieB-gu changed the title Rename Design.GuardianView To Design.Editorial Rename Design.GuardianView To Design.Editorial Jan 26, 2021
Copy link
Contributor

@oliverlloyd oliverlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense and will help people understand these designs in future

@paperboyo
Copy link

👍 (also: Observer)

@gtrufitt
Copy link

they're not prefixed with the word Guardian

GuardianView is 'The Guardian View', right?

But yes 👍

Copy link
Contributor

@joecowton1 joecowton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking 👍

@JamieB-gu
Copy link
Contributor Author

GuardianView is 'The Guardian View', right?

Is there a difference between "The Guardian View" and an "Editorial"?

@gtrufitt
Copy link

gtrufitt commented Jan 27, 2021

GuardianView is 'The Guardian View', right?

Is there a difference between "The Guardian View" and an "Editorial"?

Maybe, if as @paperboyo mentions, Observer is included in Editorials

image

https://www.theguardian.com/profile/editorial

But, that said, current Design Type is pointing at tone/editorials tag that includes Observer https://github.com/guardian/content-api-scala-client/blob/63ca817bb8ad49eb8869603b74ec91247c0c6bfe/client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala#L46

Carry on!

(Side note: we need to keep the scala CAPI client in sync with the Design Types)

@paperboyo
Copy link

Is there a difference between "The Guardian View" and an "Editorial"?

I hope not! 😆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants