-
Notifications
You must be signed in to change notification settings - Fork 16
[REVIEW] Some modifications #1
base: master
Are you sure you want to change the base?
Conversation
Overall looks good. In general, all of the commit messages should describe why you made the changes, because its not obvious. For the most part, the existing commit messages are describing what has changed, but that is visible from reading the code. |
You're right. I will re-apply the changes on your master with improved commit messages. |
This is just a first draft of the capabilities of the import function provided by GPGME. For now it just returns the fingerprint of the first successfully imported key. Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Adding this flag will fill in signatures-related structures when retrieving key information. Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Replace some missing features in GPGME < 1.4 with dummy values or by throwing exceptions. Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Call gpgme_check_version with the minimal compatible version and redefine some types missing in GPGME < 1.4. Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
I've reapplied the commits with some explanations. If you think they can suffice, let's comment them here. Merry Christmas by the way :-) |
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
@daniele-athome are you planning on doing a new pull request, or shall I cherry-pick these commits? |
Hey, sorry I've been busy. I was planning to rework these things in the short term (2-4 weeks):
The rest you can pick (at your choice):
The only doubt is "return first fingerprint from import". How do you think we should proceed on that? |
No apologies necessary! Just checking in :-) Your future work stuff sounds very useful. I'll pick the commits you mentioned for now, to get things working on older versions of gpgme. As for "return first fingerprint from import", why not always return a |
Actually the import method should return an array (or a list) of classes describing the imported result in detail (much like the import struct used in gpgme). But let's start with a fingerprint array of successfully imported keys. |
returning an array of the imported keys makes sense. But that might now fit |
Hello Committers, Sorry for posting comment here.. There is no issue creation option to create issue in this project.. |
I created this PR to let you review my modifications and eventually create one or more selective PRs to do the actual merges (or, if you like all of them, you might merge this PR as well).