Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things Addressed Here:
The about dialog had a lot of broken URLs and words stuck together because it is partially populated by the LICENSE file which was read in
OrbotMainActivity
'sreadFromAssets(Context, String)
. The issue here is that the file is read withBufferedReader
'sreadLine()
which terminates strings at a line feed or carriage return. The fix was to simply append a linefeed after every line theBuferedReader
reads (these newlines are later transformed into<br/>
elements when the About dialog is getting configured).It's easy to see what I mean via these screenshots:
You can see in the first URL the "If" from the next sentence is squished against it causing users to have a 404 when they click on it.
With the linefeed fix we no longer have broken URLs and it's a bit easier to read too.
I also changed Wifi into Wi-Fi