Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UI String Fixes #127

Merged
merged 3 commits into from Apr 20, 2018
Merged

Some UI String Fixes #127

merged 3 commits into from Apr 20, 2018

Conversation

bitmold
Copy link
Collaborator

@bitmold bitmold commented Feb 27, 2018

Things Addressed Here:

  • The License dialog was read from the file without any newlines causing it to be crammed and have its hyperlinks 404.
  • Some tiny string fixes (..,. appeared in some spots, and also Wi-Fi was referred to by an incorrect variation of Wi-Fi in a good number of places in the app)

The about dialog had a lot of broken URLs and words stuck together because it is partially populated by the LICENSE file which was read in OrbotMainActivity's readFromAssets(Context, String). The issue here is that the file is read with BufferedReader's readLine() which terminates strings at a line feed or carriage return. The fix was to simply append a linefeed after every line the BuferedReader reads (these newlines are later transformed into <br/> elements when the About dialog is getting configured).

It's easy to see what I mean via these screenshots:

license-bad

You can see in the first URL the "If" from the next sentence is squished against it causing users to have a 404 when they click on it.

license-better

With the linefeed fix we no longer have broken URLs and it's a bit easier to read too.

I also changed Wifi into Wi-Fi

@bitmold
Copy link
Collaborator Author

bitmold commented Mar 6, 2018

Additionally on the play store there is a typo on the screenshot for Tor bridges. There is an ellipsis with a comma between the second and third period. I searched the project for that string, and it still occurs in the Dutch translation so I added that fix to this PR.

It would be good to post a corrected screenshot on the playstore.

image

@n8fr8 n8fr8 merged commit f151b37 into guardianproject:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants