Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent: Add OTP fetching to the island api client #3101

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Mar 13, 2023

What does this PR do?

Fixes a task in #3077

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (cef8508) 67.64% compared to head (79433da) 67.65%.

❗ Current head 79433da differs from pull request most recent head 48c5393. Consider uploading reports for the commit 48c5393 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3101      +/-   ##
===========================================
+ Coverage    67.64%   67.65%   +0.01%     
===========================================
  Files          445      445              
  Lines        12760    12764       +4     
===========================================
+ Hits          8632     8636       +4     
  Misses        4128     4128              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VakarisZ VakarisZ mentioned this pull request Mar 13, 2023
8 tasks
Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the HTTPIslandAPIClient going handle all authentication and therefore we don't need to expose those methods in the IIslandAPIClient?

Copy link
Contributor

@shreyamalviya shreyamalviya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method needs to be added to the IIslandAPIClient too.

@VakarisZ VakarisZ merged commit 03e1c6b into develop Mar 14, 2023
@VakarisZ VakarisZ deleted the 3077-agent-fetch-otp branch March 14, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants