Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak OTP in logs #3123

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Don't leak OTP in logs #3123

merged 9 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. Agent: Add OTPFormatter class in main.py

    @shreyamalviya @VakarisZ
    shreyamalviya authored and VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f1b132e View commit details
    Browse the repository at this point in the history

  2. Agent: Modify logger to use OTPFormatter so that OTPs aren't leaked i… 

    …n logs
    @shreyamalviya @VakarisZ
    shreyamalviya authored and VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    75f9d58 View commit details
    Browse the repository at this point in the history

  3. Common: Add secret variable 

    This secret variable is a utility to gide output of variables into logs
    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    797d677 View commit details
    Browse the repository at this point in the history

  4. Common: Add OTP type

    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    56428a4 View commit details
    Browse the repository at this point in the history

  5. Agent: Cast OTP to a SecretVariable 

    Casting OTP and using it as a SecretVariable means that OTP won't get logged
    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2c3b7cc View commit details
    Browse the repository at this point in the history

  6. Common: Change "get_secret_value" return type to Any 

    Theoretically SecretVariable should support any data type, intergace should reflect it
    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9185d73 View commit details
    Browse the repository at this point in the history

  7. UT: Remove unnecessary comments in test_secret_variable.py

    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3c737db View commit details
    Browse the repository at this point in the history

  8. Common: Change the OTP typehint to an interface

    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d7e6869 View commit details
    Browse the repository at this point in the history

  9. Agent: Catch all authentication errors to not leak the OTP

    @VakarisZ
    VakarisZ committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ccf0aba View commit details
    Browse the repository at this point in the history