Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Improvement/232 dont show linux in cred map #338

Merged
merged 8 commits into from Jun 12, 2019

Conversation

@ShayNehmad
Copy link
Contributor

ShayNehmad commented Jun 5, 2019

Feature / Fixes

Changes/Fixes the following feature

Fixes #232 .

  • Have you added an explanation of what your changes do and why you'd like to include them?

  • Have you successfully tested your changes locally?

  • Example screenshot/log transcript of the feature working
    Running on an environment with a Linux machine and a Windows machine:
    image

PTH map only shows Windows machine:
image

Changes

  • Filtering only Windows machines into the PTH map.
  • Using the DAL in "generate_map_nodes"
  • Covered "generate_map_nodes" in UTs
  • Added get_os to the Monkey model
@ShayNehmad ShayNehmad requested a review from itaymmguardicore Jun 5, 2019
@ShayNehmad ShayNehmad changed the title [WIP] Improvement/232 dont show linux in cred map [CR] Improvement/232 dont show linux in cred map Jun 5, 2019
@ShayNehmad ShayNehmad self-assigned this Jun 5, 2019
@danielguardicore danielguardicore merged commit 015081f into develop Jun 12, 2019
@danielguardicore danielguardicore deleted the improvement/232-dont-show-linux-in-cred-map branch Jun 12, 2019
@ShayNehmad ShayNehmad changed the title [CR] Improvement/232 dont show linux in cred map [DONE] Improvement/232 dont show linux in cred map Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.