Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending application/json with an optional Scope #1490

Merged

Conversation

blast-hardcheese
Copy link
Member

A stub for now, but wiring through the scope parameter to ApplicationJson to enable #1120

@github-actions github-actions bot added core Pertains to guardrail-core java-async-http Pertains to guardrail-java-async-http java-dropwizard Pertains to guardrail-java-dropwizard java-spring-mvc Pertains to guardrail-java-spring-mvc java-support Pertains to guardrail-java-support scala-akka-http Pertains to guardrail-scala-akka-http scala-dropwizard Pertains to guardrail-scala-dropwizard scala-support Pertains to guardrail-scala-support labels May 23, 2022
@blast-hardcheese blast-hardcheese added the minor Bump minor version label May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1490 (b659f8c) into master (07a2a30) will increase coverage by 0.06%.
The diff coverage is 75.71%.

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
+ Coverage   83.28%   83.34%   +0.06%     
==========================================
  Files          88       88              
  Lines        5510     5507       -3     
  Branches      142      147       +5     
==========================================
+ Hits         4589     4590       +1     
+ Misses        921      917       -4     
Impacted Files Coverage Δ
...yncHttpClient/AsyncHttpClientClientGenerator.scala 94.27% <50.00%> (+0.28%) ⬆️
...s/scala/dropwizard/DropwizardServerGenerator.scala 83.48% <50.00%> (ø)
...ail/generators/scala/akkaHttp/AkkaHttpHelper.scala 70.37% <66.66%> (ø)
...tors/java/springMvc/SpringMvcServerGenerator.scala 90.32% <70.00%> (+1.43%) ⬆️
...ators/scala/akkaHttp/AkkaHttpServerGenerator.scala 91.14% <71.42%> (ø)
...a/dev/guardrail/java/helpers/ResponseHelpers.scala 89.47% <75.00%> (ø)
.../dev/guardrail/scala/helpers/ResponseHelpers.scala 89.47% <75.00%> (ø)
...rs/java/dropwizard/DropwizardServerGenerator.scala 94.71% <88.88%> (ø)
...ators/scala/akkaHttp/AkkaHttpClientGenerator.scala 94.15% <100.00%> (ø)
...enerators/scala/http4s/Http4sClientGenerator.scala 92.59% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a2a30...b659f8c. Read the comment docs.

@blast-hardcheese blast-hardcheese merged commit 47bc1c2 into guardrail-dev:master May 23, 2022
@blast-hardcheese blast-hardcheese deleted the application-json-scope branch May 23, 2022 20:12
@blast-hardcheese blast-hardcheese added the enhancement Functionality that has never existed in guardrail label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pertains to guardrail-core enhancement Functionality that has never existed in guardrail java-async-http Pertains to guardrail-java-async-http java-dropwizard Pertains to guardrail-java-dropwizard java-spring-mvc Pertains to guardrail-java-spring-mvc java-support Pertains to guardrail-java-support minor Bump minor version scala-akka-http Pertains to guardrail-scala-akka-http scala-dropwizard Pertains to guardrail-scala-dropwizard scala-support Pertains to guardrail-scala-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant