makefile: add support for passing docs serve addr #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 40.91% 40.91%
=======================================
Files 16 16
Lines 980 980
=======================================
Hits 401 401
Misses 579 579
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ShreyaR
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
@devenbhooshan this makes sense!
I like the idea of having instructions in the readme for running tests and serving docs. I added at #52 to track that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very, very tiny change.
I added the ability to serve docs from different ports. I run some other services at this port on localhost. It is a good practice to expose this.
Separate suggestion
To ease the development, we should add
How to run tests/docs/ locally guidein the readme. One can check themakefile, but it would be good to put it in the readme to make it more obvious.