fix require for images and remove breaking template tag #36
Conversation
There was a problem hiding this comment.
Hello @vein101
Thank you for your contribution 🎉
I marked a few things to be reviewed before merging this.
If you are okay with that, I'll wait for you to see and make those changes or we can discuss them.
If you don't have time, let me know then I can make those changes for you once I have some time.
We also need to add this new prop into the storybook (stories folder) as well probably have a unit test to cover it (tests folder), before pushing to NPM.
There was a problem hiding this comment.
Thank you for all the changes!
I tested this on a Vue 3 project and it worked 😄
Thank you also for updating the documentation, as well the story and adding the tests. I really appreciate your work into this 🎉
I'll do a couple more tests today, and maybe change a thing on two, but I'll generate the next release either later today or tomorrow (if everything still works great).
But I'll merge this now since everything seems to be just fine.
Thank you again!
No description provided.