Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package structure: put any of project structures in a separated packages #8

Closed
gucio321 opened this issue May 17, 2021 · 1 comment
Closed

package structure: put any of project structures in a separated packages #8

gucio321 opened this issue May 17, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers Normal Priority

Comments

@gucio321
Copy link
Owner

it is a time, to split this d2s package into a several smaller 😀

+ d2s
   + d2sirongolem
    + d2smerc
    + d2sitems
        + itemdata
    + d2sdifficulty

e.t.c.
@gucio321 gucio321 added enhancement New feature or request good first issue Good for newcomers Normal Priority labels May 17, 2021
@gucio321
Copy link
Owner Author

also need to split some long methods to avoid nolint directives

gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
b8eda00 
move difficulty.go into d2sdifficulty package
@gucio321 gucio321 mentioned this issue May 17, 2021
Closed
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
c75a066 
- move iron_golem.go into d2sirongolem package
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
a9c28f9 
- move version.go into d2enums package
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
fbe516f 
- move merc_type.go -> d2smercenary/mercenary.go
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
c649cf5 
- move npc.go into d2snpc package
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
2be2d52 
- waypoints.go -> d2swaypoints/
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
ed81f70 
- move skill_id.go into d2senums package
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
2780bad 
- move quests.go into d2squests package
gucio321 added a commit that referenced this issue May 17, 2021
@gucio321
package structure (#8):
25ff8de 
- move status.go into d2sstatus package
gucio321 added a commit that referenced this issue May 18, 2021
@gucio321
d2s.go: extract Skills from main file; move it to a separated package (…
34ad271 
…#8)
gucio321 added a commit that referenced this issue May 26, 2021
@gucio321
d2s: extract hotkeys structure from d2s.go; move it into d2shotkeys (…
9f482bb 
…#8)
@gucio321 gucio321 mentioned this issue May 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Normal Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gucio321