Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split long methods to avoid nolint directive (d2sitems, d2s.go) #9

Closed
gucio321 opened this issue May 17, 2021 · 1 comment
Closed

split long methods to avoid nolint directive (d2sitems, d2s.go) #9

gucio321 opened this issue May 17, 2021 · 1 comment
Assignees
@gucio321
Labels
good first issue Good for newcomers lintfix related with lint errors Low Priority nothing urgent, there are more important things

Comments

@gucio321
Copy link
Owner

also need to split some long methods to avoid nolint directives

Originally posted by @gucio321 in #8 (comment)
@gucio321 gucio321 added good first issue Good for newcomers Low Priority nothing urgent, there are more important things labels May 17, 2021
@gucio321 gucio321 self-assigned this May 18, 2021
gucio321 added a commit that referenced this issue May 18, 2021
@gucio321
all: make some progress for #9
8b12871
gucio321 added a commit that referenced this issue May 18, 2021
@gucio321
all: cut D2S.Encode (#9)
37e0686
@gucio321 gucio321 added the lintfix related with lint errors label May 18, 2021
@gucio321 gucio321 mentioned this issue May 20, 2021
Closed
gucio321 added a commit that referenced this issue May 20, 2021
@gucio321
d2sitems: split long methods (#9)
3a5620d
gucio321 added a commit that referenced this issue May 21, 2021
@gucio321
d2sstats: clean loading/unloading stats to avoid nolint (#9); add u…
45f2539 
…nittest for d2sstats (close #32)
@gucio321
Copy link
Owner Author

gucio321 commented Sep 6, 2021

d2s.go is done atm

@gucio321 gucio321 closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucio321 gucio321

Labels
good first issue Good for newcomers lintfix related with lint errors Low Priority nothing urgent, there are more important things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gucio321