Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing six dependency #614

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Add missing six dependency #614

merged 1 commit into from
Aug 22, 2019

Conversation

sharkykh
Copy link
Contributor

The code clearly uses six, so it should have it listed as a dependency.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.014% when pulling 809e175 on sharkykh:patch-1 into ca60ce6 on guessit-io:develop.

@Toilal
Copy link
Member

Toilal commented Aug 22, 2019

Thanks, good catch (but still don't understand how build can pass without it ...)

@Toilal Toilal merged commit bc65e99 into guessit-io:develop Aug 22, 2019
@sharkykh
Copy link
Contributor Author

sharkykh commented Aug 22, 2019

but still don't understand how build can pass without it ...

I'm pretty sure Travis-CI has some version of six v1.11.0 pre-installed on Python builds.
Requirement already satisfied, skipping upgrade: six in /home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages (from guessit==3.0.5.dev0) (1.11.0)

Also, rebulk depends on it, so it could get installed from that:
Requirement already satisfied, skipping upgrade: six in /home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages (from rebulk->guessit==3.0.5.dev0) (1.11.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants