Feature/update guessit #7081
Merged
Feature/update guessit #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p0psicles
commented
Aug 22, 2019
•
p0psicles
commented
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
* Used sharks medusa_vendor_tools.
p0psicles
force-pushed
the
feature/update_guessit
branch
from
8ae5f87
to
97d6fc9
Compare
p0psicles
commented
Aug 22, 2019
sharkykh
reviewed
Aug 22, 2019
sharkykh
previously approved these changes
Aug 22, 2019
p0psicles
commented
Aug 22, 2019
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| https://codeload.github.com/pymedusa/adba/tar.gz/112c04b50d318802b4a0c7924f8e26aaf9e60a5b#egg=adba | |||
| https://codeload.github.com/Diaoul/babelfish/tar.gz/f403000dd63092cfaaae80be9f309fd85c7f20c9#egg=babelfish | |||
| adba @ https://codeload.github.com/pymedusa/adba/tar.gz/112c04b50d318802b4a0c7924f8e26aaf9e60a5b#egg=adba | |||
There was a problem hiding this comment.
@sharkykh our build is having issues with the "adba @ ...." Should I revert those changes?
There was a problem hiding this comment.
Oh are you talking about security/snyk?
There was a problem hiding this comment.
I didn't realize they couldn't read this format. I'll revert it.
There was a problem hiding this comment.
Nope, I guess it's something else, because it's still failing.
|
I'll check again tomorrow. Tnx for the support. Really nice tool! |
sharkykh
approved these changes
Aug 22, 2019
|
@medariox do you know what's going on? |
|
Snyk has some issues atm. Let's ignore it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.