Use path objects instead of strings #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installation paths are now treated as App::Perlbrew::Path instances though in refactoring some paths were not adapted Related issue: gugod#657
3 similar comments
added 2 commits
May 5, 2019 09:54
resolve_stable_version cannot return string stable so second comparison will always fail. Preferring conditional evaluation over ternary operator as far as variable is already populated.
happy-barney
force-pushed
the
brz-dev-issue-657
branch
from
02dc796
to
14be48c
Compare
Cover not only parameter passing into `do_install_archive()` but also its processing inside.
gugod
reviewed
May 9, 2019
| sub should_install_from_archive { | ||
| my ($title, %params) = @_; | ||
|
|
||
| Hash::Util::lock_keys %params, |
There was a problem hiding this comment.
I'm not sure why this is needed, but I guess it's a nice add-on.
gugod
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation paths are now treated as App::Perlbrew::Path instances
though in refactoring some paths were not adapted
Related issue: #657