make-pp: include privlib #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privlib usually contains all "core modules".
Core modules are only included in PAR if they are detected
as a dependency by pp. In case of detection failures, the
only way to manually put a core module in a PAR would be
to add -M paramaters.
Here is one such failure case:
# pp --bundle -o ack =ack
# ls | ./ack a
Undefined subroutine &Term::ANSIColor::colored called at script/ack line 995, <STDIN> line 1.
# unzip -l ack | grep Term
13043 08-23-2023 09:37 lib/Term/Cap.pm
About Term::ANSIColor
# corelist Term::ANSIColor
Data for 2023-07-02
Term::ANSIColor was first released with perl v5.6.0
# perldoc -l Term::ANSIColor
/home/gugod/perl5/perlbrew/perls/perl-5.38/lib/5.38.0/Term/ANSIColor.pm
The obvious way to overkill this problem is to always include the entire
privlib in the PAR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privlib contains all core libs and therefore should be part of the output.