Nixos (and others) compatibility #801
Conversation
There was a problem hiding this comment.
Looks great to me. I'll merge the PR once I unbreak whatever I broke under the github workflow directory....
BTW The change in META.json does not seem to be necessary, and it will most likely be undone by the the release procedure, since I pretty much let mbtiny manage the content of META.json these days...
| @@ -49,7 +49,8 @@ | |||
| "Test::Output" : "1.03", | |||
| "Test::Simple" : "1.001002", | |||
| "Test::Spec" : "0.49", | |||
| "Test::TempDir::Tiny" : "0.016" | |||
| "Test::TempDir::Tiny" : "0.016", | |||
| "Test::Which" : "1.27" | |||
There was a problem hiding this comment.
It does not look like Test::Which is directly used in the new test, we can probably remove this change.
Actually I pretty much just depend on mbtiny to generate META.json / META.yml for me these days...
There was a problem hiding this comment.
Interesting... CI failed at missing Test::Switch. I guess I'll need to tweak how I use mbtiny a little bit to accommodate this addition.
| if [ -o hashall ] ; then | ||
| hash -r | ||
| fi |
There was a problem hiding this comment.
A very nice little detail that I've been missing... thanks for adding this!
NixOS does not install a system Perl in a standard location (it uses either a global perl in
/run/current-system/sw/binor a Perl in the/nix/store/* tree. This patch allows someone to add an additional system perl library location via thePERLBREW_SYSTEM_PERLenvironmental variable.In addition, NixOS configures the user's bash shell with the hashall option off. The bashrc file in Perlbrew executes
hash -rwhich fails because hashing is disabled. This patch adds a check of the hashall option before attempting to clear the hash cache.I'm open to any changes you might desire to accept this PR.