Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the TestViewsDisposeCorrectly was not doing what it was supposed to do #2964

Merged
merged 28 commits into from Nov 15, 2023

Conversation

a-usr
Copy link
Contributor

@a-usr a-usr commented Nov 9, 2023

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit // test fails now (which is good, as the reason for that is that a certain view doesnt dispose correctly.)
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@a-usr
Copy link
Contributor Author

a-usr commented Nov 9, 2023

While testing this i found out that toplevels create multiple references to their subviews that arent being released upon disposal.
Please see #2965

@a-usr a-usr marked this pull request as ready for review November 14, 2023 06:50
@a-usr a-usr requested a review from tig as a code owner November 14, 2023 06:50
@a-usr
Copy link
Contributor Author

a-usr commented Nov 14, 2023

TestViewsDisposeCorrectly does now sucessfully check wether or not all views can be disposed. Aditionally @BDisp did a great job at fixing an issue where Toplevel was holding references to its subviews even after they where disposed.

TestVKPacket is acting up again. Maybe the test is running async and is receiving scan codes from other instances?
@tig tig merged commit c7942ae into gui-cs:develop Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants