Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3518. v1 NetDriver throws System.InvalidOperationException when a key is pressed. #3519

Merged
merged 6 commits into from
Jun 9, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented May 30, 2024

Fixes

Proposed Changes/Todos

  • Put the Console.ReadKey inside a try/catch block
  • Also fixes an issue where the cursor isn't showing when the cursor is visible
  • Add support for Suspend method

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner May 30, 2024 21:00
Copy link
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle this differently.

If possible, avoid the problem rather than eating the exception, because there are other valid reasons for that exception to be thrown.

Terminal.Gui/ConsoleDrivers/NetDriver.cs Outdated Show resolved Hide resolved
@tig tig merged commit ab86c4f into gui-cs:develop Jun 9, 2024
4 checks passed
@BDisp BDisp deleted the v1_3518-netdriver-readkey-fix branch June 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 NetDriver throws System.InvalidOperationException when a key is pressed.
3 participants