Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard for running build from setup.py, redirecting users to pip #805

Merged
merged 3 commits into from
May 7, 2024

Conversation

Harsha-Nori
Copy link
Collaborator

Resolves #801 . I thought we could use lazy imports and setup_requires to get python setup.py build, but I kept running into challenges with guaranteeing an install of PyBind11 and setuptools_rust ahead of executing the code.

Pointing users to pip based systems is more robust, especially since we already have a pyproject.toml file.

@Harsha-Nori Harsha-Nori merged commit b2522fd into main May 7, 2024
108 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python setup.py build not working
2 participants