Support cgroup v2 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has now been tested on a cgroups v1 and a cgroups v2 node and appears to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to drop some stats
memory.max_usage_in_bytesbecomesmemory.peak, but this is not in any currently released kernel (torvalds/linux@8e20d4b, looks like it will be part of 6.8)cpuacct.usage_percpuis exposed via eBPF in kernel 6.6+, but not though cgroupfs although it might be for a future kernel. I'm not sure I want to write BPF tooling just for that. Not to mention that our cluster is on kernel 5.15 anyway, so it wouldn't work.