Make timestamp param position consistent. Add some tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places it was before id, in others it was after the id. Makes it always to be placed before the id param
Adds drop-schema to TimeSeries. It's needed to cleanup the db in tests
| @@ -20,7 +20,7 @@ | |||
| information for the fact on all the specified categories") | |||
|
|
|||
| (inc! [service id categories] | |||
| [service id timestamp categories] | |||
| [service timestamp id categories] | |||
There was a problem hiding this comment.
@guilespi I'm changing the params order here, to make it consistent with new-fact params order. What do you think?
The id is more important than the timestamp, so it should appear first
|
@guilespi: Changed the params order, so id appears before timestamp. How does it look now? |
guilespi
added a commit
that referenced
this pull request
Nov 17, 2014
Make timestamp param position consistent. Add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.