Make the plugin compatible with Gedit >= 3.12 (I believe, tested on 3.14) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcepl
changed the title
Used mostly description at http://www.micahcarrick.com/writing-plugins-for-gedit-3-in-python.html and examples from other existing complying plugings. Fixes #10
|
Thanks! I merged the branch. I am a bit annoyed by the cosmetic changes that should have been put into an other pull request. But well, since I don't maintain the plugin anymore these days, I am not going to complain. |
You are right. I have flake8 switched on so usually fix all those nits as I go. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could I hope to get some feedback on this suggested solution, please?