Fix accessibility #1280
Fix accessibility #1280
Conversation
stevenMouret
commented
Jan 8, 2019
stevenMouret
commented
- Fix aria-describedby when using data-parsley-error-message
- Manage aria-hidden attribute on error wrapper
…r-message - Add aria-hidden attribute on error wrapper
| var removeDescribedby = this._ui.$errorClassHandler | ||
| .removeAttr('aria-describedby'); | ||
|
|
||
| return removeErrorMessage && removeDescribedby; |
There was a problem hiding this comment.
This return statement makes no sense to me. Simplest change would be to first removeAttr('aria-describedby') then do as before, no?
There was a problem hiding this comment.
Bonjour Marc andré,
I am not sure to understand. In the case there is no input assistance, it is necessary to remove aria-describedby. If we do not remove aria-describedby the technical assistance will try to read an empty ul.
There was a problem hiding this comment.
Please re-read carefully what I wrote. Nowhere do I propose not removing the aria-describedby.
There was a problem hiding this comment.
Hello Marc André,
Sorry this pull request is open for some time now.
Maybe it is possible to do more simple, but I am not a JS expert. The chunk of code you are highlighting just allow to remove the aria-describedby and the error message. If it is possible to make more simple do not hesitate to refactoring my code. If you need more explanation about the this accessibility changes I can explain more.
|
Great, thanks for the PR. I commented on a |
|
I've pushed a modified commit to master, but I'm running into issues on Travis. I've wasted an hour of my life on incompatibilities that seem to me completely ridiculous but it's still not working. |
I think you're getting the wrong issue. My changes do not affect dependencies. |
Indeed, there is no doubt about that.
No. I'm just explaining where I'm at. I have never thought or implied that your commit, or my modified version of it, was responsible for the troubles on Travis. |
|
Merged in with modifications as a1a5d36 Should be fixed in 2.9.2 Thanks again for the PR 👍 |
