Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize locale #55

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Normalize locale #55

merged 1 commit into from
Nov 12, 2021

Conversation

Stadly
Copy link
Contributor

@Stadly Stadly commented Nov 11, 2021

Normalize locales, so the locale from gettext files and the lang attribute become compatible.

Closes #54.

Normalize locales, so the locale from [gettext files](https://www.gnu.org/software/gettext/manual/gettext.html#Locale-Names) and the [`lang` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang) become compatible.

Closes #54.
@guillaumepotier guillaumepotier merged commit 727bc0e into guillaumepotier:master Nov 12, 2021
@guillaumepotier
Copy link
Owner

Thanks a lot @Stadly your help is much appreciated :) Best

@Stadly
Copy link
Contributor Author

Stadly commented Nov 15, 2021

You're welcome. Thanks for the library :)

Any plans on making a new release with this fix?

@guillaumepotier
Copy link
Owner

@Stadly here your are : https://github.com/guillaumepotier/gettext.js/releases/tag/v1.1.0

@Stadly
Copy link
Contributor Author

Stadly commented Nov 15, 2021

NPM is not updated yet. Do you have to do it manually?

@Stadly
Copy link
Contributor Author

Stadly commented Nov 15, 2021

Maybe it is because package.json says "version": "1.0.1"?

@guillaumepotier
Copy link
Owner

Right.

I've created a new v1.1.1 tag and properly added it to package.json + npm publish.

Let me know

Best

@Stadly
Copy link
Contributor Author

Stadly commented Nov 16, 2021

Working! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when translation locale and target locale don't match exactly
2 participants