Adds robustness to the zremrangebyrank method #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into an error when removing the last item of a set, and then trying to trim a set down to a specific cap. With Redis, I don't need to check the length of a set before calling
zremrangebyrank
so I don't want to put that check in my production code. The set is missing because it gets removed byremove_key_for_empty_collection
.Here is the pseudocode for repro. This block will apply a diff update to an existing list, but fails in FakeRedis if the last item gets removed:
This pull request adds the same validation all the other methods use (see
zrevrangebyscore
), and also moves the method above next to its cousinzremrangebyscore
rather than being next to the disssimilarzinterstore
andzunionstore