-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing .vintageousrc not parsing omap, vmap; adding nmap #956
Open
cchrisman
wants to merge
4
commits into
guillermooo:master
Choose a base branch
from
cchrisman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0b6d14a
.vintageousrc now reads :map or map as a starting token, and now acce…
cchrisman db2f4af
Removing errant print statement.
cchrisman 52657b6
Removing resolution of mappings in partials.
cchrisman ac03cd1
Merge remote-tracking branch 'upstream/master'
cchrisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,53 @@ | ||
from Vintageous import PluginLogger | ||
|
||
import sublime | ||
|
||
import os | ||
|
||
|
||
_logger = PluginLogger(__name__) | ||
|
||
|
||
class DotFile(object): | ||
def __init__(self, path): | ||
self.path = path | ||
|
||
@staticmethod | ||
def from_user(): | ||
path = os.path.join(sublime.packages_path(), 'User', '.vintageousrc') | ||
return DotFile(path) | ||
|
||
def run(self): | ||
try: | ||
with open(self.path, 'r') as f: | ||
for line in f: | ||
cmd, args = self.parse(line) | ||
if cmd: | ||
_logger.info('[DotFile] running: {0} {1}'.format(cmd, args)) | ||
sublime.active_window().run_command(cmd, args) | ||
except FileNotFoundError: | ||
pass | ||
|
||
def parse(self, line): | ||
try: | ||
_logger.info('[DotFile] parsing line: {0}'.format(line)) | ||
if line.startswith((':map ')): | ||
line = line[1:] | ||
return ('ex_map', {'command_line': line.rstrip()}) | ||
|
||
if line.startswith((':omap ')): | ||
line = line[len(':omap '):] | ||
return ('ex_omap', {'cmd': line.rstrip()}) | ||
|
||
if line.startswith((':vmap ')): | ||
line = line[len(':vmap '):] | ||
return ('ex_vmap', {'cmd': line.rstrip()}) | ||
|
||
if line.startswith((':let ')): | ||
line = line[1:] | ||
return ('ex_let', {'command_line': line.strip()}) | ||
except Exception: | ||
print('Vintageous: bad config in dotfile: "%s"' % line.rstrip()) | ||
_logger.debug('bad config inf dotfile: "%s"', line.rstrip()) | ||
|
||
return None, None | ||
from Vintageous import local_logger | ||
import sublime | ||
import os | ||
_logger = local_logger(__name__) | ||
class DotFile(object): | ||
def __init__(self, path): | ||
self.path = path | ||
@staticmethod | ||
def from_user(): | ||
path = os.path.join(sublime.packages_path(), 'User', '.vintageousrc') | ||
return DotFile(path) | ||
def run(self): | ||
try: | ||
with open(self.path, 'r') as f: | ||
for line in f: | ||
cmd, args = self.parse(line) | ||
if cmd: | ||
_logger().info('[DotFile] running: {0} {1}'.format(cmd, args)) | ||
sublime.active_window().run_command(cmd, args) | ||
except FileNotFoundError: | ||
pass | ||
def parse(self, line): | ||
try: | ||
_logger().info('[DotFile] parsing line: {0}'.format(line)) | ||
line = line.lstrip(':') | ||
if line.startswith(('map ')): | ||
return ('ex_map', {'command_line': line.rstrip()}) | ||
if line.startswith(('omap ')): | ||
return ('ex_omap', {'command_line': line.rstrip()}) | ||
if line.startswith(('nmap ')): | ||
return ('ex_nmap', {'command_line': line.rstrip()}) | ||
if line.startswith(('vmap ')): | ||
return ('ex_vmap', {'command_line': line.rstrip()}) | ||
if line.startswith(('let ')): | ||
return ('ex_let', {'command_line': line.strip()}) | ||
except Exception: | ||
print('Vintageous: bad config in dotfile: "%s"' % line.rstrip()) | ||
_logger().debug('bad config inf dotfile: "%s"', line.rstrip()) | ||
return None, None |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: does Vim allow spaces before
:
in config files? If so, we'd need to account for it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empirically vim seems to ignore trailing and leading whitespace in .vimrc lines, so the code could probably be simplified with a line = line.trim() first thing, then you can remove the rstrip.