Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorization breaks if you have single quote in comment #11

Closed
jmesserly opened this issue Mar 5, 2013 · 3 comments
Closed

colorization breaks if you have single quote in comment #11

jmesserly opened this issue Mar 5, 2013 · 3 comments

Comments

@jmesserly
Copy link
Contributor

in web_ui code:

    for (var library in libraries) {
      // We don't need this anymore, so free it.
      library.referencedBy = null;
    }
  }

everything under the "we don't need it" line is getting colored as if it is a string

@timothyarmstrong
Copy link
Contributor

Looks like this is being triggered because it thinks the variable library is the built-in identifier library.

I'll see if I can come up with a good solution for this.

@jmesserly
Copy link
Contributor Author

Ah! good catch. I'll try renaming that and see if it fixes. That's a nice workaround :)

@ghost ghost assigned timothyarmstrong Mar 5, 2013
@jmesserly
Copy link
Contributor Author

yup, that did it. I renamed our vars to "lib" and colorization is fixed. Would still be nice to get this bug fixed but in the meantime it's an easy workaround. Thanks!

guillermooo added a commit that referenced this issue Sep 10, 2014
Fix #11 - Improve syntax def when using 'library' keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants