-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check command #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments, all small mainly for consistency but it looks good!
|
||
## Check | ||
|
||
Check whether current generated files are up to date with the yaml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if its worth documenting here why you might want to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some documentation, hope that's what you meant.
@@ -3,11 +3,13 @@ import * as generateBookmarks from "./generate-bookmarks.js"; | |||
import * as saveBookmarks from "./save-bookmarks.js"; | |||
import * as mergeBookmarks from "./merge-bookmarks.js"; | |||
import * as convertBookmarks from "./convert-bookmarks.js"; | |||
import * as checkBookmarks from "./check-bookmarks.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add this to the developer readme my to explain how the functions can be used to be consistent with other modules. Its just a quick note for people who might want to import into other projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation.
Looks good, thanks so much for the contribution I will merge and publish |
Solve #1
Add a check command to check whether the currently generated files are up to date.