Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/mobile clickthrough #80

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Hotfix/mobile clickthrough #80

merged 2 commits into from
Jan 23, 2020

Conversation

edrpls
Copy link

@edrpls edrpls commented Jan 23, 2020

This will fix an issue when the VPAID click is handled by the player #79
Additionally, it will hide the timestamps when either duration or current time is not available.

@edrpls edrpls merged commit fda5d86 into master Jan 23, 2020
@edrpls
Copy link
Author

edrpls commented Jan 23, 2020

This issue occurred on certain VPAID tags that delegate the click on mobile to the player, VASTTracker was not able to return one, so the clickthrough event was never emitted. The fix was to pass the VPAID URL to VASTTracker.click(url), which uses the argument passed as a fallback.

On our side the VAST 2.0 recommended flow is still used, VPAID URL -> VAST URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant