Skip to content

Commit

Permalink
fix(rxjs): Use lettable operators instead of prototype mutation
Browse files Browse the repository at this point in the history
closes #118
  • Loading branch information
Alex Malkevich committed Apr 19, 2018
1 parent c1ee504 commit 91c1cbd
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
2 changes: 0 additions & 2 deletions src/dynamic/dynamic.directive.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'rxjs/add/operator/takeUntil';

import { SimpleChanges } from '@angular/core';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
Expand Down
3 changes: 2 additions & 1 deletion src/dynamic/dynamic.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
Optional,
SimpleChanges,
} from '@angular/core';
import { takeUntil } from 'rxjs/operators';
import { Subject } from 'rxjs/Subject';

import { COMPONENT_INJECTOR, ComponentInjector } from './component-injector';
Expand Down Expand Up @@ -168,7 +169,7 @@ export class DynamicDirective implements OnChanges, DoCheck, OnDestroy {
Object.keys(outputs)
.filter(p => compInst[p])
.forEach(p => compInst[p]
.takeUntil(this._outputsShouldDisconnect$)
.pipe(takeUntil(this._outputsShouldDisconnect$))
.subscribe(outputs[p]));
}

Expand Down
1 change: 0 additions & 1 deletion src/polyfills.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ import 'core-js/es6/reflect';

import 'core-js/es7/reflect';
import 'zone.js/dist/zone';
import './rxjs.imports';
1 change: 0 additions & 1 deletion src/rxjs.imports.ts

This file was deleted.

0 comments on commit 91c1cbd

Please sign in to comment.