Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rxjs 6 support #118

Closed
Gidmark opened this issue Apr 10, 2018 · 2 comments · Fixed by #124
Closed

Rxjs 6 support #118

Gidmark opened this issue Apr 10, 2018 · 2 comments · Fixed by #124
Labels
enhancement

Comments

@Gidmark
Copy link

Gidmark commented Apr 10, 2018

Any plans on supporting Rxjs 6? Atm i get errors when it tries to include "rxjs/Subject" which should be "rxjs" and rxjs/add/operator/takeUntil which should be "rxjs/operators"
@gund
Copy link
Owner

gund commented Apr 11, 2018

Hi, yes, it is better to rely on lettable operators.

There is only one operator used (takeUntil) so it should be a pretty minor thing.
If you want, you are more than welcome to make a PR for it =)

gund pushed a commit that referenced this issue Apr 19, 2018
fix(rxjs): Use lettable operators instead of prototype mutation
91c1cbd 
closes #118
@gund gund mentioned this issue Apr 19, 2018
Merged
@gund gund closed this as completed in #124 Apr 19, 2018
@gund
Copy link
Owner

gund commented Apr 19, 2018

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use lettable operators instead of prototype mutation gund/ng-dynamic-component
2 participants
@gund @Gidmark