Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow movements #23

Merged
merged 18 commits into from May 15, 2017
Merged

Flow movements #23

merged 18 commits into from May 15, 2017

Commits on Apr 5, 2017

  1. Configuration menu
    Copy the full SHA
    f27d766 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Backing up a version of ELEMENT jumps that's mostly working. I'm

    considering incorporating the BRACKET jumps into the same function, so I
    wanted to establish a rollback point.
    bpstahlman committed Apr 8, 2017
    Configuration menu
    Copy the full SHA
    fd53f8a View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2017

  1. Both of the new unconstrained movements (flow into lists and move by

    non-list elements crossing list boundaries) are basically working.
    Checking in work before beginning on documentation and cleanup.
    bpstahlman committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    76d8f66 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2017

  1. Completed significant documentation and cleanup of the flow commands.

    Just realized there's a good use-case for visual mode versions of these
    commands. Establishing a rollback point before implementing...
    bpstahlman committed Apr 10, 2017
    Configuration menu
    Copy the full SHA
    c39c6ec View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2017

  1. Added visual mode versions of the list flow commands. Since visual mode

    flow commands need cursor to remain on near side of element when visual
    mode is re-activated, added an optional arg to select_current_marks(),
    which allows desired cursor position (which obviously must correspond to
    one of the visual marks) to be specified. Need to clean up and document.
    Also need to add visual mode support for the element flow commands.
    bpstahlman committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    0071296 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2017

  1. Got a version of flow_to_adjacent_element working. Need to decide

    whether to modify logic to use end of visual selection in desired
    direction as start of search. Currently, I use cursor position
    unconditionally, but it occurs to me that if a single element is
    selected, it's likely the user would want the jump to move to a
    different element, not just a different side of the current one.
    bpstahlman committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    78cd1a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2017

  1. Finished up implementation of visual mode "flow" commands, and updated

    the documentation. Did a bit of cleanup and commenting in the source
    file, but more is needed...
    bpstahlman committed Apr 15, 2017
    Configuration menu
    Copy the full SHA
    b47df9d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2017

  1. Added "flow out" variants of the list flow commands, and renamed all

    list flow commands to note the distinction between in/out flow. Began
    (but didn't finish) updating the documentation. Also, changed "element"
    to "nonlist" in what were previously known as "element flow" commands,
    to reflect the fact that a list can't be a target of a non-list flow
    command (though a list can be an element in normal vim-sexp parlance).
    bpstahlman committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    cfb2de0 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2017

  1. Much rework in documentation. Still need to update code to reflect

    naming changes, but wanted to backup.
    bpstahlman committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    ec12bbe View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2017

  1. Finished naming changes for flow commands and mostly updated

    documentation to reflect the changes. A bit more cleanup needed, but
    wanted to establish rollback point before picking one of the alternate
    presentations of the list flow command documentation.
    bpstahlman committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    8d24e77 View commit details
    Browse the repository at this point in the history
  2. Cleaned up all of movements branch except for s:leaf_flow, which needs a

    bit more rework to handle character literals and comments properly.
    bpstahlman committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    aeb8267 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2017

  1. Fixed handling of brackets at end of comment or in character literal;

    however, I'm thinking of going to a simpler fix, which is more robust,
    albeit possibly a bit less efficient.
    bpstahlman committed May 2, 2017
    Configuration menu
    Copy the full SHA
    4bf0481 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2017

  1. Configuration menu
    Copy the full SHA
    fe9c793 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2017

  1. Fixed some comments.

    bpstahlman committed May 7, 2017
    Configuration menu
    Copy the full SHA
    a4c3818 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2017

  1. Committing rollback point before removing logic from leaf_flow, which

    was added to handle some edge cases that aren't handled any where else
    in vim-sexp.
    bpstahlman committed May 13, 2017
    Configuration menu
    Copy the full SHA
    345de6d View commit details
    Browse the repository at this point in the history
  2. --list_flow--

    Reworked handling of BOF/EOF for list_flow to make more consistent with
    the philosophy of accepting whatever we find as target: e.g., I now
    select the list corresponding to the final bracket of desired type, even
    if cursor started on it. Also, fixed bug whereby only parens were
    treated as brackets.
    --leaf_flow--
    Simplified logic significantly after deciding not to handle (admittedly
    somewhat pathological) edge cases that the rest of vim-sexp doesn't
    handle. Commented the rationale in the function header.
    --Cleanup--
    Final review and commenting of flow functions (both list and leaf).
    Removed alternate (but now dead) implementations of leaf_flow.
    bpstahlman committed May 13, 2017
    Configuration menu
    Copy the full SHA
    18d7b8f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2017

  1. Removed unused variable.

    bpstahlman committed May 14, 2017
    Configuration menu
    Copy the full SHA
    526b9e3 View commit details
    Browse the repository at this point in the history
  2. Bugfix: Parens were hardcoded where more generic s:opening_bracket

    should have been used.
    bpstahlman committed May 14, 2017
    Configuration menu
    Copy the full SHA
    656220e View commit details
    Browse the repository at this point in the history