support dynamoattribute.UnixTime on CreateTable #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag definition feature was added at #104, but minimum depends version of aws-sdk-go in go.mod is old. The field dynamodb.CreateTableInput.Tags is introduced at aws-sdk-go@v1.19.18. ref. https://github.com/aws/aws-sdk-go/releases/tag/v1.19.18 So, bump the depends.
Songmu
changed the title
|
I decided to implement support for I've released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dynamodbattribute.UnixTimeis a type for storing UNIX epoch into DynamoDB that is officially provided by "aws-sdk-go". Isn't it reasonable to treat it as "N" dynamodb.AtributeType when creating a table?How do you think?