Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute alternative description should be provided #27

Closed
dvberkel opened this issue Jan 4, 2017 · 2 comments
Closed

Attribute alternative description should be provided #27

dvberkel opened this issue Jan 4, 2017 · 2 comments

Comments

@dvberkel
Copy link
Member

dvberkel commented Jan 4, 2017

In order to create an AttributeBonus from an AttributeBonusDescription we need a way to look up an Attribute from a description found in the XML. For this the Attribute bonus got an alternativeDescription, i.e. a variable length constructor argument, detailing alternative ways of getting an Attribute.fromDescription.

I only provide strength and intelligence. The others should be provided with the identifiers found in the XML.

@mgoris
Copy link
Contributor

mgoris commented Jan 4, 2017

Identified the following values from the xml. Will handle them.

<attribute>hearing</attribute>
<attribute>taste smell</attribute>
<attribute>touch</attribute>
<attribute>vision</attribute>
<attribute limitation="lifting only">st</attribute>
<attribute>dodge</attribute>
<attribute>parry</attribute>
<attribute>block</attribute>
<attribute>fright check</attribute>
<attribute>move</attribute>
<attribute>speed</attribute>
<attribute>dx</attribute>
<attribute>ht</attribute>
<attribute>iq</attribute>
<attribute>perception</attribute>
<attribute>st</attribute>
<attribute>will</attribute>
<attribute>sm</attribute>
<attribute>fp</attribute>
<attribute>hp</attribute>
<attribute limitation="striking only">st</attribute>

@mgoris
Copy link
Contributor

mgoris commented Jan 4, 2017

Last few missing descriptions can not be added, as there are no attributes implemented yet for them. Updated the issue #28 with these missing items. Close this issue.

@mgoris mgoris closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants