Fix error with local_rank assignment #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guschmue
approved these changes
Jul 25, 2023
pnunna93
added a commit
to pnunna93/Oscar
that referenced
this pull request
Feb 26, 2024
Merge pull request guschmue#5 from pnunna93/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guschmue, the local_rank assignment in my previous PR - #4 (https://github.com/guschmue/Oscar/blob/master/oscar/run_vqa.py#L1037) is causing an error. Seems like the global declaration and assignment are not allowed in the same line.
I did test the change before pushing but somehow missed it. This PR splits global declaration and local_rank assignment which fixes the error, please check.