New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 support #5

Merged
merged 5 commits into from Dec 30, 2014

Conversation

Projects
None yet
3 participants
@cmc333333
Contributor

cmc333333 commented Dec 30, 2014

Add support for Python3 by being explicit about byte strings. Also, initialized settings in the django tests (which is required in at least django 1.7) -- based on @aroxby's fork. This uses a feature of django 1.5+ to convert back to strings as necessary, so this breaks support < 1.5.

Tests pass with Python 3.4 + django 1.7, Python 2.7 + django 1.7, Python 2.7 + django 1.6, Python 2.7 + django 1.5.

Manually tested set/get with Python 3.4 + django 1.7 (production environment).

@gusdan

This comment has been minimized.

Show comment
Hide comment
@gusdan

gusdan Dec 30, 2014

Owner

Thank you. Looks good.

Owner

gusdan commented Dec 30, 2014

Thank you. Looks good.

@gusdan gusdan closed this Dec 30, 2014

@gusdan gusdan reopened this Dec 30, 2014

gusdan added a commit that referenced this pull request Dec 30, 2014

@gusdan gusdan merged commit 2018992 into gusdan:master Dec 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment