Python3 support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3 support + django 1.7 in tests
|
Thank you. Looks good. |
matteiuspi
pushed a commit
to CashStar/django-elasticache
that referenced
this pull request
Mar 19, 2021
Deploy only specific env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Python3 by being explicit about byte strings. Also, initialized settings in the django tests (which is required in at least django 1.7) -- based on @aroxby's fork. This uses a feature of django 1.5+ to convert back to strings as necessary, so this breaks support < 1.5.
Tests pass with Python 3.4 + django 1.7, Python 2.7 + django 1.7, Python 2.7 + django 1.6, Python 2.7 + django 1.5.
Manually tested set/get with Python 3.4 + django 1.7 (production environment).