Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pull request and convert an existing issue #15

Closed
cordoval opened this issue Feb 13, 2014 · 4 comments
Closed

Create a pull request and convert an existing issue #15

cordoval opened this issue Feb 13, 2014 · 4 comments

Comments

@cordoval
Copy link
Member

imported from https://github.com/cordoval/gush/issues/77

WIth hub I can do this:

hub pull-request -b MyRepo:master -h ghi-1164 -i 1164

Which will convert issue 1164 to a pull request to MyRepo:master from dantleech:ghi-1164.

@cordoval
Copy link
Member Author

I guess @dantleech you meant it like this?

gush p:create --base=MyRepo:master --head=ghi-1164 --issue=1164

@dantleech
Copy link
Contributor

@cordoval yeah thats pretty much what hub does

@cordoval
Copy link
Member Author

ok cool so basically i should check for permissions on the repo and just do this with the api, the difference would be there will not be a table to push to the description hmm since there may be a description already. We should however still prompt for input to fill the table? So it is a modification on top of the p:create command.

Thanks @dantleech for your input!

@dantleech
Copy link
Contributor

Well, I would not prompt for a body. Note also that github want to deprecate this feature, which is annoying.

cordoval added a commit that referenced this issue Mar 19, 2014
…vert-an-existing-issue

This PR was merged into gushphp:master branch.

Discussion
----------

create a pr from an existing issue

                   
|Q            |A  |
|---          |---|
|Bug Fix?     |no |
|New Feature? |yes|
|BC Breaks?   |no |
|Deprecations?|no |
|Tests Pass?  |yes |
|Fixed Tickets|#15, #79|
|License      |MIT|
|Doc PR       |   |
                   



Commits
-------

53cae7e added issue parameter to p:create cslucano
67131db added new test to p:create cslucano
4fe04dc finish PR for creating PR with issue passed cordoval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants