-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a pull request and convert an existing issue #15
Comments
I guess @dantleech you meant it like this?
|
@cordoval yeah thats pretty much what |
ok cool so basically i should check for permissions on the repo and just do this with the api, the difference would be there will not be a table to push to the description hmm since there may be a description already. We should however still prompt for input to fill the table? So it is a modification on top of the p:create command. Thanks @dantleech for your input! |
Well, I would not prompt for a body. Note also that github want to deprecate this feature, which is annoying. |
…vert-an-existing-issue This PR was merged into gushphp:master branch. Discussion ---------- create a pr from an existing issue |Q |A | |--- |---| |Bug Fix? |no | |New Feature? |yes| |BC Breaks? |no | |Deprecations?|no | |Tests Pass? |yes | |Fixed Tickets|#15, #79| |License |MIT| |Doc PR | | Commits ------- 53cae7e added issue parameter to p:create cslucano 67131db added new test to p:create cslucano 4fe04dc finish PR for creating PR with issue passed cordoval
imported from https://github.com/cordoval/gush/issues/77
WIth hub I can do this:
Which will convert issue
1164
to a pull request toMyRepo:master
fromdantleech:ghi-1164
.The text was updated successfully, but these errors were encountered: