feat: add lowerCase and upperCase #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jly36963
commented
Oct 6, 2023
README.md
Outdated
| ### lowerCase | ||
|
|
||
| This function converts a string to `lower case` at both runtime and type levels. | ||
| _NOTE: this function will split by words and join them with `" "`._ |
There was a problem hiding this comment.
Suggestion for a better warning?
I want it to be crystal clear that toUpperCase and upperCase are significantly different
(Same with the lower counterparts)
src/casing.ts
Outdated
| /** | ||
| * Transforms a string to lowercase, with words delimited by a space. | ||
| */ | ||
| type LowerCase<T extends string> = Join<LowerCaseAll<Words<T>>, ' '> |
There was a problem hiding this comment.
Suggested change
| type LowerCase<T extends string> = Join<LowerCaseAll<Words<T>>, ' '> | |
| type LowerCase<T extends string> = Lowercase<DelimiterCase<T, ' '>> | |
| function lowerCase<T extends string>(str: T): LowerCase<T> { | |
| return toLowerCase(delimiterCase(str, ' ')) | |
| } |
README.md
Outdated
| ```ts | ||
| import { lowerCase } from 'string-ts' | ||
|
|
||
| const str = 'HELLO WORLD' |
There was a problem hiding this comment.
Maybe make it clearer
Suggested change
| const str = 'HELLO WORLD' | |
| const str = 'HELLO [WORLD]...' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.