Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #12

Closed
vivax3794 opened this issue Dec 11, 2020 · 8 comments · Fixed by #20
Closed

Testing #12

vivax3794 opened this issue Dec 11, 2020 · 8 comments · Fixed by #20
Assignees
Labels
enhancement New feature or request

Comments

@vivax3794
Copy link
Contributor

Framwork

we could use the built-in unittest to keep with the current no depends, but I really like pytest.

when the tests have been setup they should be used with #8 as well.

I would be more than happy to write the tests

@vivax3794 vivax3794 changed the title Tetsing and package Tetsing Dec 11, 2020
@vivax3794
Copy link
Contributor Author

vivax3794 commented Dec 11, 2020

to keep with the current no depends

on second thought, pytest would be a development dependency anyway, as so will flake8 and so be when that is setup

@gustavwilliam
Copy link
Owner

That would be cool. What do you think we should have tests for?

I don't have a strong preference about whether to use such dependencies or not. Either way would work imo.

@vivax3794
Copy link
Contributor Author

everything? haha. add_from_class, methods added to CodeAnswers

@gustavwilliam
Copy link
Owner

I mean, sure thing. Unit tests are very nice 😄

We should probably wait for the package logic to move from the main file to init first, though. After that, I'm all for it.

@fisher60 fisher60 changed the title Tetsing Testing Dec 12, 2020
@fisher60 fisher60 added discussion enhancement New feature or request labels Dec 12, 2020
@fisher60
Copy link
Collaborator

I am fairly biased to pytest, I find it looks much cleaner.

@gustavwilliam
Copy link
Owner

Then I see no reason to use anything else. Let's go with PyTest!

@vivax3794
Copy link
Contributor Author

great I can start work on it when #15 and #16 get merged

@gustavwilliam
Copy link
Owner

@vivax3794 we should be ready to start writing tests!

We're considering changing the way that answers are stored, but that shouldn't change the outputs of using the package in any way.

Thanks for helping out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants