-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Kate in IDE (also see comments regarding the github workflow) #16
Conversation
This change adds poetry for dependency management as well as CI and pre-commit hooks. I needed to fix one issue in answers.py. Other than that, this change should not affect much existing code. It is important that everyone follows the new contributing instructions to guarantee new code added complies with our styling
Updating mahself
Feature/ci
@fisher60 i guess it is because one or more lines really are too long inside |
since you are adding the pyproject.toml file it might be nice to just fill it out completely, I made this one when I was planning to pr in poetry. name = "bestpy"
version = "0.0.1"
description = "A module to prove your friends (or adversaries) wrong."
authors = ["Gustav Odinger"]
license = "MIT"
readme = "README.md"
repository = "https://github.com/gustavwilliam/bestpy"
classifiers = [
"Programming Language :: Python :: 3",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
] |
Hello @vivax3794. Thanks! I have filled out using what you made. Any more suggestions or changes you might want to add? Btw I am new to this stuff
|
I mainly just added in what was in the setup.py file (which can actually be deleted now that poetry is setup), here are the docs for all the attributes that can go in the file if you see any more you would want to add. |
@ReneganRonin Is this some kind of compound PR? There is already a PR from Fisher for adding Poetry, I believe. Is this adding the same thing, plus one extra name to the IDEs category? |
@gustavwilliam hello vester. yeah my bad for this pr. i do think it is best to close this and i will create a new branch to separate them and pull fisher's features/ci branch to fix the linting. then i will pr to the branch @fisher60 made instead once the linting errors are fixed. i wont pr to main. |
Sounds perfect. |
Also added Fisher's work for the github workflows.