Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Kate in IDE (also see comments regarding the github workflow) #16

Closed
wants to merge 8 commits into from
Closed

Conversation

uncomfyhalomacro
Copy link
Contributor

Also added Fisher's work for the github workflows.

fisher60 and others added 7 commits December 11, 2020 16:32
This change adds poetry for dependency management as well as CI and pre-commit hooks. I needed to fix one issue in answers.py. Other than that, this change should not affect much existing code. It is important that everyone follows the new contributing instructions to guarantee new code added complies with our styling
@uncomfyhalomacro
Copy link
Contributor Author

uncomfyhalomacro commented Dec 12, 2020

@fisher60 i guess it is because one or more lines really are too long inside answers.py. i auto-formatted it with black.

@uncomfyhalomacro uncomfyhalomacro changed the title Adding Kate in IDE Adding Kate in IDE (see comment regarding the github workflow) Dec 12, 2020
@uncomfyhalomacro uncomfyhalomacro changed the title Adding Kate in IDE (see comment regarding the github workflow) Adding Kate in IDE (also see comments regarding the github workflow) Dec 12, 2020
@vivax3794
Copy link
Contributor

vivax3794 commented Dec 12, 2020

since you are adding the pyproject.toml file it might be nice to just fill it out completely, I made this one when I was planning to pr in poetry.

name = "bestpy"
version = "0.0.1"
description = "A module to prove your friends (or adversaries) wrong."
authors = ["Gustav Odinger"]
license = "MIT"
readme = "README.md"
repository = "https://github.com/gustavwilliam/bestpy"
classifiers = [
	"Programming Language :: Python :: 3",
	"License :: OSI Approved :: MIT License",
	"Operating System :: OS Independent",
]

@uncomfyhalomacro
Copy link
Contributor Author

Hello @vivax3794. Thanks! I have filled out using what you made. Any more suggestions or changes you might want to add? Btw I am new to this stuff

[tool.poetry]
name = "bestpy"
version = "0.0.1"
description = "A module to prove your friends (or adversaries) wrong."
authors = ["Gustav Odinger"]
license = "MIT"
readme = "README.md"
repository = "https://github.com/gustavwilliam/bestpy"
classifiers = [
	"Programming Language :: Python :: 3",
	"License :: OSI Approved :: MIT License",
	"Operating System :: OS Independent",
]

[tool.poetry.dependencies]
python = "^3.8"

[tool.poetry.dev-dependencies]
flake8 = "^3.8.4"
pre-commit = "^2.9.3"

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

@vivax3794
Copy link
Contributor

I mainly just added in what was in the setup.py file (which can actually be deleted now that poetry is setup), here are the docs for all the attributes that can go in the file if you see any more you would want to add.

@vivax3794 vivax3794 mentioned this pull request Dec 12, 2020
@gustavwilliam
Copy link
Owner

@ReneganRonin Is this some kind of compound PR? There is already a PR from Fisher for adding Poetry, I believe. Is this adding the same thing, plus one extra name to the IDEs category?

@uncomfyhalomacro
Copy link
Contributor Author

@gustavwilliam hello vester. yeah my bad for this pr. i do think it is best to close this and i will create a new branch to separate them and pull fisher's features/ci branch to fix the linting. then i will pr to the branch @fisher60 made instead once the linting errors are fixed. i wont pr to main.

@gustavwilliam
Copy link
Owner

Sounds perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants