Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In css-builder.js path.dirname(config.out) got an error #229

Closed
FocusCare opened this issue Mar 23, 2017 · 2 comments
Closed

In css-builder.js path.dirname(config.out) got an error #229

FocusCare opened this issue Mar 23, 2017 · 2 comments

Comments

@FocusCare
Copy link

config.out maybe a function at rjs config.
@weirDozzz
Copy link

I ran into the same problem, which only appears when the node version is greater than 6,
My solution:
'path.dirname(config.out)' Modified to 'path.dirname(config.out.toString()) ',
Hope can help you.

@AStoker
Copy link

AStoker commented Aug 14, 2017

Related to #231

AStoker added a commit to AStoker/require-css that referenced this issue Aug 14, 2017
@AStoker
Don't break on updated Rjs out functionality
6f892b9 
Resolves: guybedford#231, guybedford#229

With new Rjs, `out` can be a function (https://github.com/requirejs/r.js/blob/master/build/example.build.js#L448). Need to support dealing with `out` as being a function. In this case, simply checking if the property is a string, and if not, `toString`-ing it will allow the `siteRoot` to be determined correctly.
@AStoker AStoker mentioned this issue Aug 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AStoker @FocusCare @weirDozzz