Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle disabled functions with curl_exec() and curl_multi_exec() #1287

Merged
merged 3 commits into from
Oct 27, 2015
Merged

Handle disabled functions with curl_exec() and curl_multi_exec() #1287

merged 3 commits into from
Oct 27, 2015

Conversation

dawehner
Copy link
Contributor

On shared hosting providers disable curl_exec() and curl_multi_exec() so the choose_handler() function
has to take that into account.

@mtdowling mtdowling merged commit 861c14c into guzzle:master Oct 27, 2015
@mtdowling
Copy link
Member

thanks!

@dawehner
Copy link
Contributor Author

Thanks you!

@@ -104,8 +104,12 @@ function debug_resource($value = null)
function choose_handler()
{
$handler = null;
if (extension_loaded('curl')) {
if (function_exists('curl_multi_exec') && function_exists('curl_exec')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have gotten some documentation IMHO, but well, if this is fine for you @mtdowling

@mtdowling
Copy link
Member

A PR that adds relevant documentation would be fine with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants