split some long lines in many #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
requested changes
Apr 23, 2018
src/Handler/StreamHandler.php
Outdated
| @@ -343,13 +343,21 @@ private function resolveHost(RequestInterface $request, array $options) | |||
| if ('v4' === $options['force_ip_resolve']) { | |||
| $records = dns_get_record($uri->getHost(), DNS_A); | |||
| if (!isset($records[0]['ip'])) { | |||
| throw new ConnectException(sprintf("Could not resolve IPv4 address for host '%s'", $uri->getHost()), $request); | |||
| throw new ConnectException(sprintf( | |||
There was a problem hiding this comment.
This should be
throw new ConnectException(
sprintf(
"Could not resolve IPv4 address for host '%s'",
$uri->getHost()
),
$request
);
src/Handler/StreamHandler.php
Outdated
| } | ||
| $uri = $uri->withHost($records[0]['ip']); | ||
| } elseif ('v6' === $options['force_ip_resolve']) { | ||
| $records = dns_get_record($uri->getHost(), DNS_AAAA); | ||
| if (!isset($records[0]['ipv6'])) { | ||
| throw new ConnectException(sprintf("Could not resolve IPv6 address for host '%s'", $uri->getHost()), $request); | ||
| throw new ConnectException(sprintf( |
AlessandroMinoccheri
force-pushed
the
split_in_many_lines
branch
from
ba1da4a
to
2e7aec0
Compare
|
Yeah, you are right, I have corrected the lines commented! |
sagikazarmark
approved these changes
Apr 23, 2018
|
Great, thanks a lot! |
|
Hello @AlessandroMinoccheri, i create a fork of this repo and release this changes into the new version(6.4.0). Namespace compatibility is 100%, and you can use my changes
Fork link: https://github.com/SomeBlackMagic/guzzle/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.