Fix logging with a string rejection #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. 👍 |
ankahla
approved these changes
Dec 10, 2019
|
I tested it in a real project and that is what I needed |
GrahamCampbell
approved these changes
Dec 10, 2019
|
@thewilkybarkid @Nyholm any news about this PR ? when it can be merged? |
gmponos
approved these changes
Dec 21, 2019
|
Hello can we rebase here with master? |
Nyholm
force-pushed
the
log-string-reason
branch
from
52199d0
to
65e8c25
Compare
|
👍 |
|
This is good to be merged in its current state. Tests are red because we are waiting on #2495 |
|
Should this be backported to 6.5? |
Nyholm
force-pushed
the
log-string-reason
branch
from
8f6dd1b
to
41427fe
Compare
Nyholm
added a commit
to Nyholm/guzzle
that referenced
this pull request
Dec 28, 2019
|
It could be backported if someone submits the PR. I would rather recommend people using 6.5 to upgrade to 7.0 =) |
|
Thank you @thewilkybarkid for fixing this. Also thank you everyone who took time to review and test it. |
|
Well, if we promise 6.x to be supported, then we kinda have to backport bugfixes, at least until everyone believes that 7.x works :P and until everyone stops using 5.x (yeah, I know) |
This was referenced Dec 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promises aren't always rejected with an exception. I haven't changed
MessageFormatteras that'd be a BC break.