Widen the Exception type to Throwable

[gmponos]

I should have these changes included on this: #2493 but I thought about later.

Please review thoroughly the code.. there might be more places that need a change.

Thank you

[GrahamCampbell]

Not necessarily. It might not make sense to catch throwables, actually. Throwables that are not exceptions are errors in the code, and probably should totally crash everything, on purpose.

[gmponos]

It might not make sense to catch throwables, actually

Yes for some of the cases of the current PR I have second thoughts also.. can you be more specific.. because I don't think that this applies everywhere..

For instance on my current PR I believe that MockHandler should accept Throwables.

[sagikazarmark]

@GrahamCampbell 's comment refers to catching \Throwables, not accepting them and I kinda agree, although in some cases those caught throwables are actually wrapped in another exception and thrown again.

[gmponos]

comment refers to catching \Throwables

Yes.. I had second thoughts too. So shall I revert every } catch (Throwable) { I did?

[sagikazarmark]

No, I don't think you should.

For example: it's probably a good thing, that promises can now catch errors too, and return them as rejection.

But I'm not sure catching errors and returning them as RequestException is a good idea.

[gmponos]

OK.. then can we have specific comments per case? :)

[Nyholm]

I very much agree with @GrahamCampbell. Catching exceptions and catching throwables are NOT the same thing.

Looking at the PR, all the changes makes sense. Like MessageFormatter or how we catch exceptions int $options['on_headers']($response).

[sagikazarmark]

tl;dr I would revert catching Throwables for now, but it should be accepted as an argument everywhere. We can revisit this decision later.